Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve crash due to permission denied on Android Play Store version #930

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: resolve crash due to permission denied on Android Play Store version #930

merged 2 commits into from
Nov 12, 2024

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Nov 1, 2024 •
edited
Loading

  1. Set android:extractNativeLibs="true" as in https://stackoverflow.com/a/64792194
  2. Set android.bundle.enableUncompressedNativeLibs=false as in https://stackoverflow.com/a/56551499

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@anhappdev
Copy link
Collaborator Author

@mohitmundhragithub Can you please test the Play Store version 4.1.0 (252)?

@anhappdev anhappdev mentioned this pull request Nov 1, 2024
Closed
@mohitmundhragithub
Copy link
Contributor

@mohitmundhragithub Can you please test the Play Store version 4.1.0 (252)?

I tried this, and it seems to work on Samsung Galaxy S23 ultra.
Seems like this is the right fix.

I had tried 1 as you pointed out in description... but never tried 2. May be both are required together.

@anhappdev
Copy link
Collaborator Author

anhappdev commented Nov 1, 2024 •
edited
Loading

I tried this, and it seems to work on Samsung Galaxy S23 ultra. Seems like this is the right fix.

Great to hear that. So it works for Qualcomm now.
We need to test on a device with Samsung backend to confirm the fix. @AhmedTElthakeb Can you please help test the fix here by installing the Play Store version 4.1.0 (252) via this link.

@anhappdev anhappdev marked this pull request as ready for review November 1, 2024 07:05
@anhappdev anhappdev requested a review from a team as a code owner November 1, 2024 07:05
@anhappdev anhappdev changed the title Set extractNativeLibs=true and enableUncompressedNativeLibs=false fix: resolve crash due to permission denied on Android Play Store version Nov 5, 2024
@freedomtan
Copy link
Contributor

Let's wait test from @Mostelk

@anhappdev anhappdev modified the milestones: v4.1, Google Play Store Nov 5, 2024
@freedomtan
Copy link
Contributor

@AhmedTElthakeb to test it or ask @Mostelk to test it.

freedomtan
freedomtan approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@freedomtan freedomtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anhappdev anhappdev merged commit 463d974 into master Nov 12, 2024
22 checks passed
@anhappdev anhappdev deleted the anh/set-extractNativeLibs branch November 12, 2024 06:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@freedomtan freedomtan freedomtan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Play Store
Development

Successfully merging this pull request may close these issues.

Test Android Play Store version
3 participants
@anhappdev @mohitmundhragithub @freedomtan